Quick pass at sample components #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizlooney
reviewed
Mar 11, 2025
Collaborator
lizlooney
left a comment
lizlooney
left a comment
There was a problem hiding this comment.
Looks good. I made a few comments.
lizlooney
reviewed
Mar 14, 2025
|
|
||
| class RevTouchSensor(Component): | ||
| def __init__(self, ports : list[tuple[PortType, int]]): | ||
| self.is_pressed = None |
Collaborator
There was a problem hiding this comment.
It seems like is_pressed should be a boolean, so the value should be False instead of None.
Collaborator
Author
There was a problem hiding this comment.
It can't be, because when the system boots up you don't know if the touch sensor is currently pressed or not. If you start out saying it isn't, then you'll get an immediate callback for pressed even though that isn't accurate. So you have to start out before your first read with something that knows it hasn't read hardware yet.
Leaving this comment open to see if you agree or not.
lizlooney
requested changes
Mar 14, 2025
alan412
changed the title
lizlooney
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a quick - what the base class might look like and a sample one. I think by requiring type hints that we might be able to get away with no blocks specific information needed.